voonhous commented on code in PR #19383:
URL: https://github.com/apache/hudi/pull/19383#discussion_r3802421711
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/KinesisSourceConfig.java:
##########
@@ -76,6 +76,17 @@ public class KinesisSourceConfig extends HoodieConfig {
.withDocumentation("AWS secret key for Kinesis. Used when connecting to
custom endpoints (e.g., LocalStack). "
+ "If not set with endpoint, uses the default AWS credential
chain.");
+ public static final ConfigProperty<String> KINESIS_ROLE_ARN = ConfigProperty
+ .key(PREFIX + "role.arn")
+ .noDefaultValue()
+ .sinceVersion("1.2.0")
Review Comment:
Applied in c1ce6df3c0e8, which also adds
`hoodie.streamer.source.kinesis.role.external.id` and `role.session.name`
(mirroring `HoodieAWSConfig`; the same gap HUDI-7699 / #11134 closed for the
Glue assume-role provider) and makes the new tests assert the selected
credentials provider via `serviceClientConfiguration().credentialsProvider()`
instead of `assertNotNull(client)`, which passed with the role-arn branch
deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
