hudi-agent commented on code in PR #19646:
URL: https://github.com/apache/hudi/pull/19646#discussion_r3818468453
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/DataSkippingUtils.scala:
##########
@@ -479,6 +482,16 @@ object ColumnStatsExpressionUtils {
@inline def genColNumNullsExpr(colName: String): Expression =
sparkAdapter.getExpressionFromColumn(col(getNullCountColumnNameFor(colName)))
@inline def genColValueCountExpr: Expression =
sparkAdapter.getExpressionFromColumn(col(getValueCountColumnNameFor))
+ @inline def genColumnIsNullExpression(colName: String): Expression = {
Review Comment:
🤖 nit: the sibling helpers in this object use the `Expr` suffix
(`genColNumNullsExpr`, `genColValueCountExpr`) — could you rename this to
`genColumnIsNullExpr` for consistency?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
