rangareddy commented on issue #17395:
URL: https://github.com/apache/hudi/issues/17395#issuecomment-5351244597
This issue was reviewed as part of the JIRA-migrated backlog triage
(HUDI-9139).
**Findings: not done on `master`.**
Instant timestamps are still raw strings.
`hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java`:
```java
:46 private final String requestedTime;
...
:73 public String requestedTime() {
:74 return requestedTime;
```
The secondary point in the description also still holds - the field and
accessor are named `requestedTime` rather than `requestedTimestamp`, which is
the naming inconsistency you objected to.
Worth being explicit in the ticket about the scope before anyone starts:
instant timestamps thread through the whole timeline API, every action
executor, the metadata table, and the on-disk instant file names themselves. A
typed POJO is the right destination, but the change is cross-cutting and
touches serialized/on-disk-adjacent surfaces, so a migration plan (and a view
on whether the string form has to remain part of any public API) is more
valuable here than the initial patch.
Keeping this open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
