rangareddy commented on issue #17385: URL: https://github.com/apache/hudi/issues/17385#issuecomment-5351242278
This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-9103). **Findings: not done - the constructor is still there.** `hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java` currently has both: ```java :162 protected HoodieTable(HoodieWriteConfig config, HoodieEngineContext context, HoodieTableMetaClient metaClient) :174 protected HoodieTable(HoodieWriteConfig config, HoodieEngineContext context, HoodieTableMetaClient metaClient, FileSystemViewManager viewManager, TaskContextSupplier supplier) ``` The five-argument form flagged in [the review comment on #12781](https://github.com/apache/hudi/pull/12781/files#r1964205520) is unchanged, and the suggested resolution - rewrite the tests so it is not needed, then delete it - has not happened. Before removing it, it is worth checking who the current callers are: if production code has picked it up since the review (rather than only tests, which was the original justification), the ticket's premise changes and it may need to stay with a documented reason instead. Keeping this open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
