rangareddy commented on issue #17380:
URL: https://github.com/apache/hudi/issues/17380#issuecomment-5351241531
This issue was reviewed as part of the JIRA-migrated backlog triage
(HUDI-9018).
**Findings: the CI-coverage gap is confirmed. Whether the tests still fail
is not yet verified.**
All four tests named in the description are present and **not** disabled on
`master`:
| test | `TestHoodieBackedMetadata` | `TestJavaHoodieBackedMetadata` |
| --- | --- | --- |
| `testTurnOffMetadataIndexAfterEnable` | :284 | - |
| `testVirtualKeysInBaseFiles` | :989 | :534 |
| `testMetadataMultiWriter` | :2730 | :1855 |
| `testMultiWriterForDoubleLocking` | :2805 | :1930 |
Your observation that "these tests are not executed by java CI" checks out
for the functional path:
-
`hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestHoodieBackedMetadata.java:218`
is annotated `@Tag("functional")`.
- `.github/workflows/bot.yml:706` runs `hudi-client/hudi-java-client` with
`-Punit-tests` only - there is no `-Pfunctional-tests` invocation for that
module.
- `azure-pipelines-20230430.yml:44` explicitly excludes
`'!hudi-client/hudi-java-client'` from its module list.
So there is a real gap: functional-tagged metadata-table tests are not being
run by any job. That is worth fixing independently of whether the four tests
currently pass.
What I did **not** verify is the other half of the report - whether those
four tests actually fail today. That needs a local run of both suites, which
this triage pass did not do. Whoever picks this up should start there, since
the CI gap means nobody has current pass/fail data.
Keeping this open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
