hudi-agent commented on code in PR #19695:
URL: https://github.com/apache/hudi/pull/19695#discussion_r3826077467
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestMetaFieldsModeE2E.java:
##########
@@ -281,6 +286,44 @@ void allModePersistsLegacyBooleanAsTrue() {
"ALL must persist populate.meta.fields=true for pre-1.3.0 readers");
}
+ private static Stream<Arguments> tableVersionsAndMetaFieldsModes() {
Review Comment:
🤖 nit: this `tableVersionsAndMetaFieldsModes()` provider is identical to the
one added in `TestHoodieTableConfig` — could you extract it into a shared
test-utility class (e.g. `HoodieTableVersionTestCases`) so that adding a new
version to cover only needs one edit?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
