rangareddy commented on issue #17302:
URL: https://github.com/apache/hudi/issues/17302#issuecomment-5365818970

   This issue was reviewed as part of the JIRA-migrated backlog triage 
(HUDI-8592).
   
   **Findings: needs a reproduction against a current build before it can be 
dispositioned.**
   
   The report is concrete and actionable as written: setting 
hoodie.parquet.outputtimestamptype=TIMESTAMP_MILLIS is ignored and the parquet 
file is always written with timestamp-micros.
   
   I have deliberately not called this one from the source. The surrounding 
code has been substantially rewritten since it was filed - table versions 8 and 
9, the `BufferedRecordMerger` family replacing payload-based merging, the 
file-group-reader migration, and the `hudi-common` package reorganisations in 
#19193 / #19195. With that much churn, inferring either "still broken" or 
"silently fixed" would be a guess rather than a finding, and both errors are 
costly here.
   
   The good news is that reproducing it is cheap: write a table with that 
option set and inspect the resulting parquet schema with parquet-tools or a 
schema read; no cluster needed.
   
   There is also no commit anywhere in the tree referencing HUDI-8592, so if 
this was fixed it was incidental to another change rather than deliberate - 
which is another reason to verify rather than assume.
   
   Keeping this open.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to