rangareddy commented on issue #17207:
URL: https://github.com/apache/hudi/issues/17207#issuecomment-5366107203
This issue was reviewed as part of the JIRA-migrated backlog triage
(HUDI-9801).
**Findings: still open.**
Not done. The storage-based lock providers still bind to cloud SDK clients
rather than to the `HoodieStorage` abstraction - the S3 path goes through
`software.amazon.awssdk.services.s3.S3Client` (visible in
`TestS3StorageBasedLockProvider`, which mocks `S3Client.builder`), with
parallel Azure and GCS implementations alongside it.
One thing worth knowing before starting: the test coverage you would
refactor against is partly disabled.
`hudi-aws/src/test/java/org/apache/hudi/aws/transaction/lock/TestS3StorageBasedLockProvider.java:58`
carries `@Disabled("HUDI-9159 The tests do not work. Disabling them to unblock
Azure CI")`, and `ITTestDynamoDBBasedLockProvider.java:58` carries
`@Disabled("HUDI-7475 ...")`. Re-enabling at least one of those first would
make this refactor much safer, since lock-provider bugs are the kind that
surface as data corruption under concurrency rather than as test failures.
That disabled-test work is tracked as #17330 (HUDI-8683) in an earlier batch.
Keeping this open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
