hudi-agent commented on code in PR #19648:
URL: https://github.com/apache/hudi/pull/19648#discussion_r3831711761
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/StringPartitionPathFormatter.java:
##########
@@ -56,6 +56,16 @@ protected String handleEmpty(String partitionPathPart) {
}
}
+ @Override
+ protected String replaceDashesWithSlashes(String partitionPathPart) {
+ return partitionPathPart.replace('-', '/');
+ }
+
+ @Override
+ protected boolean startsWithDash(String partitionPathPart) {
+ return !partitionPathPart.isEmpty() && partitionPathPart.charAt(0) == '-';
Review Comment:
🤖 nit: could you use `partitionPathPart.startsWith("-")` here? It reads more
clearly and matches how `KeyGenUtils` does the same leading-dash check.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
