voonhous commented on code in PR #19691:
URL: https://github.com/apache/hudi/pull/19691#discussion_r3838209523
##########
azure-pipelines-20230430.yml:
##########
@@ -80,6 +80,7 @@ parameters:
- 'org.apache.spark.sql.hudi.command'
- 'org.apache.spark.sql.hudi.common'
- 'org.apache.spark.sql.hudi.ddl'
+ - 'org.apache.spark.sql.hudi.dml.schema'
Review Comment:
Deliberate, but only half-defensible: ScalaTest's `-w` is a plain prefix
match with no exclusion primitive, so pointing the Azure DML job at
`org.apache.spark.sql.hudi.dml` would re-run the whole `dml.insert` set that
already has its own job. So the leaf split stays - but you are pointing at a
real gap, since nothing stopped the next `dml.*` package going dark.
Closed it in 88545658 rather than leaving it as a follow-up:
`TestSparkSqlHudiPackageStructure` now parses the `wildcardSuites` entries out
of `azure-pipelines-20230430.yml` and fails if any Scala test package under
`org.apache.spark.sql.hudi` is not named by one. The existing check could not
catch this because it treats `dml` as a single allowed package. Verified it
flags a scratch `dml.darkpkg` and passes on the tree as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
