rangareddy commented on issue #16782: URL: https://github.com/apache/hudi/issues/16782#issuecomment-5391408489
This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-8870). **Findings: confirmed on `master`.** `ExternalSpillableMap.values()` is still present at `hudi-common/src/main/java/org/apache/hudi/common/util/collection/ExternalSpillableMap.java:298`, so the API that materialises the entire map in memory - defeating the point of a disk-backed structure - is still available to callers. The iterator-based replacement the description proposes is the remaining work. Worth checking the call sites at the same time, since removing the method is only safe once they are converted. Related: #16916 (HUDI-9187) covers thread safety on this same class. Note it is already partially synchronised - there is a `synchronized (this)` block at `:111` - so that ticket is about completing the guarantee rather than introducing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
