rangareddy commented on issue #17009: URL: https://github.com/apache/hudi/issues/17009#issuecomment-5391443957
This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-9426). **Findings: not done, and now actionable in this repository.** **Where this lives now.** The Trino Hudi connector was migrated into this repository by commit `c3c936790727`, *"feat(trino): Migrate the Trino-Hudi connector into the Hudi repo (RFC-105)"* (#18837, 2026-07-27). It is the `hudi-trino/` module, with its own CI in `.github/workflows/hudi_trino_ci.yml`, `hudi_trino_compat.yml` and `hudi_trino_e2e.yml`. This ticket was filed when the connector lived in `trinodb/trino`, so it reads as out of scope here - it is not, and can now be worked in this repo. Verified on `master`: `NullableValue` is still constructed in the connector - `hudi-trino/src/main/java/io/trino/plugin/hudi/HudiUtil.java` (6 references) and `HudiSplitSource.java` (3) - and the prefilled-column path the description criticises is still in use, for example `HudiAvroSerializer.java:182` calling `prefilledColumnValues.appendTo(...)`. Both halves of the ask still stand: avoid the repeated `NullableValue` allocations for `domain#includesNullableValue`, and give `getPrefilledColumnValue` a cleaner signature than a long list of placeholder arguments. Keeping this open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
