rangareddy commented on issue #17022: URL: https://github.com/apache/hudi/issues/17022#issuecomment-5391446918
This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-9434). **Findings: half done - the tests landed, the refactor did not.** **Where this lives now.** The Trino Hudi connector was migrated into this repository by commit `c3c936790727`, *"feat(trino): Migrate the Trino-Hudi connector into the Hudi repo (RFC-105)"* (#18837, 2026-07-27). It is the `hudi-trino/` module, with its own CI in `.github/workflows/hudi_trino_ci.yml`, `hudi_trino_compat.yml` and `hudi_trino_e2e.yml`. This ticket was filed when the connector lived in `trinodb/trino`, so it reads as out of scope here - it is not, and can now be worked in this repo. **Done:** `hudi-trino/src/test/java/io/trino/plugin/hudi/util/TestHudiAvroSerializer.java` now exists, so the "does not have any unit tests" half of this ticket is addressed. **Not done:** `hudi-trino/src/main/java/io/trino/plugin/hudi/util/HudiAvroSerializer.java` is still 548 lines, with a static `appendTo(Type type, Object value, BlockBuilder output)` at `:206` called from `:182` and `:185`. The "very long and unmaintainable" half stands. The useful consequence: now that tests exist, the refactor is safe to do - which it was not when this was filed. That reordering is worth noting so the remaining work is not deferred again on risk grounds. Keeping this open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
