rangareddy commented on issue #17078:
URL: https://github.com/apache/hudi/issues/17078#issuecomment-5391456640

   This issue was reviewed as part of the JIRA-migrated backlog triage 
(HUDI-9573).
   
   **Findings: still open.**
   
   An audit task, but with a real starting point that is worth separating from 
the sweep. The description carries a concrete `ClassCastException` chain:
   
   ```
   CommitMetadataSerDeV2.deserialize(CommitMetadataSerDeV2.java:88)
     -> HoodieTimeline.readNonEmptyInstantContent(HoodieTimeline.java:153)
     -> HoodieTimeline.readRollbackPlan(HoodieTimeline.java:244)
     -> 
HoodieTableMetadataUtil.getRollbackedCommits(HoodieTableMetadataUtil.java:2034)
   ```
   
   That path - deserializing a rollback plan through the generic 
commit-metadata serde - is fixable on its own, and it is a real failure rather 
than a code-quality concern.
   
   The broader "inspect all forced casting in the repo" half has no completion 
criterion, so as written this ticket cannot be finished. Recommend splitting: 
one ticket for the rollback-plan deserialization cast, and if the sweep is 
still wanted, scope it to a module or add a static-analysis rule so it is 
enforceable rather than one-off.
   
   Keeping this open.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to