rangareddy commented on issue #17090: URL: https://github.com/apache/hudi/issues/17090#issuecomment-5391457512
This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-9595). **Findings: confirmed not done.** The wrapper logic is still implemented against Hadoop's `FileSystem` rather than `HoodieStorage`: - `hudi-hadoop-common/src/main/java/org/apache/hudi/hadoop/fs/HoodieWrapperFileSystem.java` - `hudi-hadoop-common/src/main/java/org/apache/hudi/hadoop/fs/HoodieRetryWrapperFileSystem.java` and no `HoodieWrapperStorage` - the class the description proposes - exists anywhere in the tree. Worth pairing with #17207 (HUDI-9801), which asks to standardize the `StorageBasedLockProvider` write clients on `HoodieStorage`. That is the same underlying problem: behaviour bound to a concrete filesystem or cloud SDK rather than to the storage abstraction. Deciding once what `HoodieStorage` is responsible for - retries, wrapping, metrics, locking - would serve both, whereas doing them separately risks two different answers. Keeping this open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
