deepakpanda93 commented on code in PR #19494: URL: https://github.com/apache/hudi/pull/19494#discussion_r3842739461
########## hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestLogAppender.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.testutils; + +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.core.LogEvent; +import org.apache.logging.log4j.core.Logger; +import org.apache.logging.log4j.core.appender.AbstractAppender; + +import java.util.ArrayList; +import java.util.List; +import java.util.UUID; + +/** + * Collects the log events a logger emits, so a test can assert on what was logged. + * <p> + * Attach it around the code under test and detach it afterwards: + * <pre>{@code + * HoodieTestLogAppender appender = new HoodieTestLogAppender(); + * appender.attachTo(SomeClass.class); + * try { + * // exercise the code + * } finally { + * appender.detach(); + * } + * }</pre> + * Named so that surefire does not mistake it for a test class. + */ +public class HoodieTestLogAppender extends AbstractAppender { + + private final List<LogEvent> log = new ArrayList<>(); Review Comment: Agreed, renamed in `5dd2f5b3a53a`. The field is `capturedEvents` and the accessor is `getCapturedEvents()`, including the usage example in the class javadoc. Worth mentioning what the rename had to avoid. Grepping the repo for `getLog()` turns up five hits, not three: ``` hudi-cli/.../TestRepairsCommand.java:310, :445 hudi-common/.../TestPriorityBasedFileSystemView.java:153, :889 hudi-common/.../HoodieTestLogAppender.java:60 ``` The first four belong to two separate private `TestLogAppender` inner classes, `TestRepairsCommand:433` and `TestPriorityBasedFileSystemView:877`, which are unrelated to this one. A repo-wide rename would have modified two test classes this PR has no business touching, so only this appender and its two consumers, `TestRetryHelper` and `TestHoodiePartitionMetadata`, were changed. That does mean the duplication raised earlier in this PR is wider than the two copies consolidated here: there are two more appenders of essentially the same shape. Folding those into `HoodieTestLogAppender` looks worthwhile, but this PR has already grown from a logging fix into a test utility plus an exception handling change, so I would rather not widen it again. Happy to follow up separately if a committer agrees. Also rebased onto master in the same push, the branch was 26 commits behind. Re-verified afterwards: `TestRetryHelper` 4/4, `TestHoodiePartitionMetadata` 8/8, and `checkstyle:check` plus `apache-rat:check` clean on `hudi-common` and `hudi-hadoop-common`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
