voonhous commented on code in PR #19713:
URL: https://github.com/apache/hudi/pull/19713#discussion_r3851475719
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/others/TestPartialUpdateForMergeInto.scala:
##########
@@ -732,12 +732,144 @@ class TestPartialUpdateForMergeInto extends
HoodieSparkSqlTestBase {
}
}
+ // A partial update names only the columns being changed, so the record key
is normally absent
Review Comment:
The existing test at lines 611-681 is the nearest shape to #19712
(partitioned MOR, `GLOBAL_SIMPLE`, partial `UPDATE SET`, mixed `INSERT`,
partition change) and has no assertions at all; it also runs with the default
`update.partition.path=true`, so partial updates are off in it, which is why it
never caught this, and line 634 sets `hoodie.index.global.index.enable`, which
is not a config anywhere in the tree. Relatedly,
`TestMergeIntoTable.scala:1496-1498` has its MOR rows commented out citing
HUDI-8835, fixed 2025-05-15 by #13263; that table is partitioned,
partial-update, has no preCombineField and already sets the small-file limit to
0.
Could we give the test here a `checkAnswer` on the rows plus
`_hoodie_partition_path`, set `update.partition.path=false` and drop the bogus
key, and re-enable those two MOR rows in `TestMergeIntoTable`, so the
mixed-clause, compaction and commit-time-ordering shapes are covered without
another cell?
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/others/TestPartialUpdateForMergeInto.scala:
##########
@@ -732,12 +732,144 @@ class TestPartialUpdateForMergeInto extends
HoodieSparkSqlTestBase {
}
}
+ // A partial update names only the columns being changed, so the record key
is normally absent
Review Comment:
Two more on that test while you are there: line 634 sets
`hoodie.index.global.index.enable`, which is not a config anywhere in the tree,
so it is silently dropped. And `TestMergeIntoTable.scala:1496-1498` has its MOR
rows commented out citing HUDI-8835, fixed 2025-05-15 by #13263; that table is
partitioned, partial-update, has no preCombineField and already sets the
small-file limit to 0.
Could we re-enable those two rows instead of adding a commit-time-ordering
cell here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
