voonhous opened a new pull request, #19732:
URL: https://github.com/apache/hudi/pull/19732
…backed reader
HudiTrinoFileReaderFactory.newParquetFileReader threw
UnsupportedOperationException, and hudi-common's ArchivedTimelineLoaderV2
obtains its reader for the LSM history files under .hoodie/timeline/history
from that factory. Since #14019 the archived timeline is loaded lazily, so the
throw surfaces whenever a completion time of an archived instant is needed,
e.g. file slicing of a MOR table whose log file belongs to an archived delta
commit.
Add TrinoParquetFileReader, a HoodieAvroFileReader over Trino's
ParquetReader that turns each page into an IndexedRecord through
HudiAvroSerializer, honouring the projection the loader requests and converting
VARBINARY values to the ByteBuffer that ArchivedTimelineV2 expects for the
metadata and plan columns. Key, key-prefix and row-key lookups are unsupported:
timeline files carry none of the data-file footer metadata those rely on.
Ported from onehouseinc/trino#72 and adapted to the HoodieSchema-based
reader contract, the PrefilledColumnValues serializer and Trino 484's
ParquetReader API. Fixtures: a four-instant history file for the reader unit
test and tv8 COW/MOR tables with archived timelines for the smoke test; the MOR
fixture's oldest log file belongs to an archived delta commit, so its
read-optimized and real-time cases fail on master and pass with this change.
Fixes #13994
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
