voonhous commented on code in PR #18923:
URL: https://github.com/apache/hudi/pull/18923#discussion_r3854351931
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkParquetReader.java:
##########
@@ -144,16 +144,28 @@ public ClosableIterator<UnsafeRow>
getUnsafeRowIterator(HoodieSchema requestedSc
*/
public ClosableIterator<UnsafeRow> getUnsafeRowIterator(HoodieSchema
requestedSchema, List<Filter> readFilters) throws IOException {
HoodieSchema nonNullSchema = requestedSchema.getNonNullType();
- StructType structSchema =
HoodieInternalRowUtils.getCachedSchema(nonNullSchema);
+ return getUnsafeRowIterator(nonNullSchema,
HoodieInternalRowUtils.getCachedSchema(nonNullSchema), readFilters);
+ }
+
+ /**
+ * Variant overload. {@code projectedStructSchema} is the requested Spark
schema, which may carry
Review Comment:
Reworded: the javadoc now leads with what the overload does (it uses
`projectedStructSchema` as the Spark read schema directly, preserving the Spark
4.1 `VariantMetadata` that `HoodieSchema` cannot represent) instead of the
"Variant overload." label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
