hudi-agent commented on code in PR #19575: URL: https://github.com/apache/hudi/pull/19575#discussion_r3859109998
########## hudi-common/src/main/java/org/apache/hudi/common/config/metrics/HoodieMetricsConfig.java: ########## Review Comment: 🤖 **Line 117:** This doc still describes the old behavior: the counters were written into the commit extra metadata, but this PR publishes them only to the metrics reporter. The warning about permanent timeline/archive footprint no longer applies. Could you reword it for reporter-only publishing? Also, since master metrics default off but this defaults to true, the executor accumulator still runs (reporting nothing) on every RLI table by default, so it may be worth a line on why one would still disable it. <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
