hudi-agent commented on code in PR #19741: URL: https://github.com/apache/hudi/pull/19741#discussion_r3859196515
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/BaseZookeeperBasedLockProvider.java: ########## Review Comment: 🤖 **Line 190:** One subtle side effect of moving the close into `finally`: previously an exception from `curatorFrameworkClient.close()` was caught and logged by this catch block, but now it would propagate out of `close()` uncaught. Is that acceptable for callers, or would it be safer to wrap the `finally` close in its own try/catch-and-log so `close()` stays non-throwing? <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
