rangareddy commented on issue #16600: URL: https://github.com/apache/hudi/issues/16600#issuecomment-5434688898
This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-8165). **Findings: not done.** There is no LRU or in-memory-cache logic in `hudi-common/src/main/java/org/apache/hudi/common/util/collection/ExternalSpillableMap.java`. **#16588 (HUDI-8114) in this same batch asks for the in-memory cache itself**, and this ticket asks for its eviction policy - they are one piece of work and should be done together. Two more tickets touch the same class and are worth coordinating with: #16782 (avoid calling `values()`, which materialises the whole map and defeats the disk-backed design) and #16916 (thread safety - note the class is already partially synchronised, with a `synchronized (this)` block at `:111`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
