rangareddy commented on issue #16605: URL: https://github.com/apache/hudi/issues/16605#issuecomment-5434689807
This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-8170). **Findings: not done on `master`.** There is no `ReaderState` or `ReaderContextState` class anywhere in the tree, so the state the description wants extracted still lives directly on `HoodieReaderContext`. Two notes on the linked PRs, since together they read misleadingly: - **#11827** (`[HUDI-8170] Create Reader State Class to remove state from the reader context`) - this ticket's own PR - is **closed unmerged**. So the `status:pr-available` label implies a patch awaiting review when there is none. - **#11943** (`[HUDI-8203] Make record merge mode the primary merging config`) is merged, but carries a different JIRA key - it is the PR whose review raised this, not a fix for it. Worth pairing with #16695 (HUDI-8417), which asks for `HoodieReaderContext.setRecordMerger` to stop taking an `Option` - the same "simplify the reader context" cleanup, and both touch the same class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
