rangareddy commented on issue #16641:
URL: https://github.com/apache/hudi/issues/16641#issuecomment-5434693109
This issue was reviewed as part of the JIRA-migrated backlog triage
(HUDI-8269).
**Findings: probably obsolete - flagging it as a scope question rather than
asserting a verdict.**
This asks to fix the Presto integration tests in the docker demo "once Hudi
Presto integration is updated with 1.0 release". The project appears to have
moved in a different direction since.
Commit `0db52460cfa6`, `test(trino): add a Trino E2E testcontainers pipeline
for the RFC-105 connector` (#19217), says in its own message:
> The trino-coordinator-1 service is gone from every compose file, the
`ITTestHoodieDemo` trino steps have been commented out since the
HUDI-8269/HUDI-8270 breakage, and the integ2 Trino E2E suite now covers the
same stock-ticks queries against the native RFC-105 connector.
and it removed the dead `ITTestBase` helpers, the `ITTestHoodieDemo`
constants and the `trino-*.commands` demo files.
So demo-based engine integration tests are being retired in favour of a
native connector E2E suite. Two caveats before concluding:
- That commit addresses the **Trino** side. `docker/demo/presto-*.commands`
still exist, and `ITTestHoodieDemo.java:104` is `@Disabled("HUDI-8440")` with
its Presto steps commented out at `:132`.
- There is **no `hudi-presto` module** in this repository at all - the
Presto connector lives in `prestodb/presto`, so "updating Hudi Presto
integration" is not work that can happen here.
Given both, this looks superseded rather than pending. But that is a
maintainer call, so I am not recommending closure - could someone confirm
whether the Presto demo path is being retired the same way the Trino one was?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
