voonhous commented on code in PR #19163:
URL: https://github.com/apache/hudi/pull/19163#discussion_r3871134272
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/insert/TestInsertTable2.scala:
##########
@@ -693,6 +695,164 @@ class TestInsertTable2 extends HoodieSparkSqlTestBase {
}
}
+ test("Test bulk insert with insert overwrite partition in dynamic mode") {
Review Comment:
Since the pending-clustering test below got its dynamic leg, this test is
subsumed: same statement, same three assertions, same
`getPartitionToReplacedFileIds` branch. Its only unique path is the
`fileGroupsInPendingClustering.isEmpty()` early return, which every existing
bulk-insert test already takes. The comment above also misattributes the
mechanism: `resolveTargetPartitions` runs only when a plan is pending, the
replaced set here comes from `getPartitionToReplacedFileIds`. Could we drop
this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
