hudi-agent commented on code in PR #19727:
URL: https://github.com/apache/hudi/pull/19727#discussion_r3871577515
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDBucketIndexPartitioner.java:
##########
@@ -121,7 +122,9 @@ private JavaRDD<HoodieRecord<T>>
doPartitionAndSortByRecordKey(JavaRDD<HoodieRec
LOG.warn("Bucket index does not support global sort mode, the sort will
only be done within each data partition");
}
- Comparator<HoodieKey> comparator = (Comparator<HoodieKey> & Serializable)
(t1, t2) -> t1.getRecordKey().compareTo(t2.getRecordKey());
+ Comparator<HoodieKey> comparator =
table.getMetaClient().getTableConfig().isLSMTreeStorageLayout()
Review Comment:
🤖 nit: the two ternary branches differ only in the string-compare call —
could you pull the boolean out and build a single comparator (e.g. select a
`BiFunction<String,String,Integer>` and wrap it once) to avoid duplicating the
lambda?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
