mailtoboggavarapu-coder commented on PR #19772: URL: https://github.com/apache/hudi/pull/19772#issuecomment-5444451952
Thanks for the review! To confirm — yes, the merged try block still has both `catch (HoodieException e)` (rethrows as-is) and `catch (Exception e)` (wraps in `HoodieSchemaFetchException`), so exception handling is intact. On the error message: connection failures will now surface as "Unable to fetch schema from <table>" instead of "Failed to connect to jdbc" — that's a minor cosmetic change and I think the new message is acceptable since it still conveys the failure context. On `conn.close()` in the finally: try-with-resources suppresses close() exceptions when a primary exception is already being propagated, so there's no risk of masking the original failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
