Davis-Zhang-Onehouse commented on code in PR #19717:
URL: https://github.com/apache/hudi/pull/19717#discussion_r3874846964
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -504,6 +531,20 @@ private void initializeMetadataPartition(
* @param initializationTime Timestamp from dataset to use for initialization
* @return a unique timestamp for MDT
*/
+ /**
Review Comment:
Done, moved the original Javadoc back down onto generateUniqueInstantTime.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -435,8 +453,16 @@ private void initializeMetadataPartition(
Indexer indexer,
String dataTableInstantTime,
Map<String, List<FileInfo>> partitionToAllFilesMap,
- Lazy<List<FileSliceAndPartition>> lazyMergedFileSlices) throws
IOException {
- String instantTimeForPartition =
generateUniqueInstantTime(dataTableInstantTime);
+ Lazy<List<FileSliceAndPartition>> lazyMergedFileSlices,
+ Option<String> requestedIndexPartition) throws IOException {
Review Comment:
Done, renamed to requestedIndexPartitionOpt.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/index/secondary/SecondaryIndexer.java:
##########
@@ -73,11 +73,8 @@ public SecondaryIndexer(
@Override
public List<IndexInitializationPlan>
buildInitialization(IndexInitializationContext context) throws IOException {
- Set<String> secondaryIndexPartitionsToInit =
getSecondaryIndexPartitionsToInit(SECONDARY_INDEX,
dataTableWriteConfig.getMetadataConfig(), dataTableMetaClient);
- if (secondaryIndexPartitionsToInit.size() > 1) {
- log.warn("Skipping secondary index initialization as only one secondary
index bootstrap at a time is supported for now. Provided: {}",
secondaryIndexPartitionsToInit);
- return Collections.emptyList();
- }
+ Set<String> secondaryIndexPartitionsToInit =
resolvePartitionsToInit(context,
+ getSecondaryIndexPartitionsToInit(SECONDARY_INDEX,
dataTableWriteConfig.getMetadataConfig(), dataTableMetaClient), "secondary
index");
Review Comment:
Done, resolvePartitionsToInit now takes the MetadataPartitionType and the
messages print SECONDARY_INDEX / EXPRESSION_INDEX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
