voonhous commented on code in PR #19424: URL: https://github.com/apache/hudi/pull/19424#discussion_r3877805353
########## website/docs/s3_hoodie.md: ########## @@ -61,6 +61,8 @@ Alternatively, add the required configs in your core-site.xml from where Hudi ca </property> ``` +Because Hudi reads and writes through the Hadoop S3A connector, these same `fs.s3a.*` settings target Amazon S3 as well as other S3-compatible object stores such as Backblaze B2, Cloudflare R2, and MinIO. For a non-AWS provider, set `fs.s3a.endpoint` to that provider's endpoint (for example `https://your-s3-endpoint.example.com`) and keep `fs.s3a.path.style.access` set to `true` when the provider requires path-style addressing. Review Comment: The setting is in the example above: the core-site.xml block this paragraph follows already carries fs.s3a.path.style.access = true (next to fs.s3a.endpoint), so "keep" reads correctly against it. The S3A default is false, as you say, but the page never asks readers to rely on the default. No change needed. ########## website/docs/s3_hoodie.md: ########## @@ -61,6 +61,8 @@ Alternatively, add the required configs in your core-site.xml from where Hudi ca </property> ``` +Because Hudi reads and writes through the Hadoop S3A connector, these same `fs.s3a.*` settings target Amazon S3 as well as other S3-compatible object stores such as Backblaze B2, Cloudflare R2, and MinIO. For a non-AWS provider, set `fs.s3a.endpoint` to that provider's endpoint (for example `https://your-s3-endpoint.example.com`) and keep `fs.s3a.path.style.access` set to `true` when the provider requires path-style addressing. Review Comment: @goanpeca yes, please fold it in: AGENTS.md on asf-site (line 68) asks for last_modified_at to be set to the current timestamp (YYYY-MM-DDTHH:MM:SS) whenever a page carrying the field is edited. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
