voonhous commented on code in PR #19164: URL: https://github.com/apache/hudi/pull/19164#discussion_r3878043381
########## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/util/CachingIterator.scala: ########## @@ -26,6 +26,10 @@ package org.apache.hudi.util * * NOTE: [[hasNext]] and [[next]] are purposefully marked as final, requiring iteration * semantic to be implemented t/h overriding of a single [[doHasNext]] method + * + * TODO: this Scala trait has no production users -- the reader path uses the Java Review Comment: Deleted the trait instead in 4b42201475a9. It has no users on master (`git grep` finds only its own definition; the reader path moved to the Java `common.util.collection.CachingIterator` in #10137), so a tracked TODO would only schedule a two-line deletion. The two `CachingIterator` tests go with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
