zhaoyudi-creator opened a new pull request, #19785:
URL: https://github.com/apache/hudi/pull/19785

   ### Change Logs
   A MOR file group can have its latest file slice keyed on a base instant
   that never committed. For example, under NBCC with the bucket index a
   delta commit fails (or is rolled back) while later delta commits on the
   same file group succeed; log files are attributed to a slice by completion
   time, so the failed instant's log and the later committed logs land in one
   slice whose base instant is the failed one.
   
   `isFileSliceCommitted` only checked whether the base instant itself was
   committed, so the whole slice — including its committed log files — was
   treated as uncommitted and dropped from the reader view, silently losing
   committed data.
   
   Fix: also consider a slice committed when any of its log files carries a
   committed delta commit time. Read-side `filterUncommittedFiles` /
   `filterUncommittedLogs` still trims the individual uncommitted log, so only
   committed logs are read.
   
   The change is inert for table version < 8: there every log file in a slice
   shares the slice's base instant as its file-name token, so an uncommitted
   base implies all-uncommitted log tokens and the new clause cannot fire.
   
   ### Impact
   Restores correct MOR read results when a file slice's base instant belongs
   to a failed/rolled-back delta commit. No public API change.
   
   ### Risk level: low
   Narrowly widens slice visibility; covered by two new unit tests and
   verified to be a no-op for pre-v8 layouts. 
   
   ### Documentation Update
   None.
   
   ### Contributor's checklist
   - [x] Read through the [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Change Logs and Impact were stated clearly
   - [x] Adequate tests were added if applicable
   - [ ] CI passed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to