voonhous commented on PR #19791: URL: https://github.com/apache/hudi/pull/19791#issuecomment-5462649124
@Joy-2000 verified all of the above at 7c36e9ba and resolved the threads. Two notes: - `validate-pr` is red because the body's `### Change Logs` heading needs to be `### Summary and Changelog`; the compliance script looks for that exact section between the problem statement and `### Impact`. - The row writer does reach `preWrite`: `bulkInsertAsRow` calls `startCommit`, then `executor.execute` -> `preExecute` -> `preWrite`. So the backstop fires there too (after the instant is requested, which is why the early `HoodieSparkSqlWriter` guard is still worth keeping), and it now also catches `BUCKET_RESCALE` under NB-CC through the inherited `INSERT_OVERWRITE` op type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
