voonhous commented on PR #19463: URL: https://github.com/apache/hudi/pull/19463#issuecomment-5468807349
Two more things on this branch, flagging both since one of them rewrote history. **Rebased onto master** (`8e884960820a`), which force-pushed the branch. Your commit is now `13e1ee560bb3` rather than `d286fd42`, so reset any local copy before you next work on it. Clean rebase, no conflicts, even though master had touched five of the same files. Worth knowing: master's `InputFormatTestUtil` change also fixed the `testParquetInlineReader` failure that was red before. **Folded one more fix in** (`cfbf4f867ea3`): `setColumnTypeList` counts the read-column ids after blanks are dropped, but its size-mismatch message printed only the raw conf value and neither count, so the string it prints can hold more entries than the number the check compared. That is the same defect this PR fixes in `orderFields`, one file over. The existing sentence is unchanged and `#nonBlankIds` / `#projectionColumns` are appended, pinned by a test. `hudi-hadoop-mr` is 232 tests green post-rebase, checkstyle and rat clean. `TestHiveTableSchemaEvolution` passes 5/5 and fails 2/5 with the production files reverted, so the coverage arm added earlier discriminates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
