danny0405 commented on code in PR #19794:
URL: https://github.com/apache/hudi/pull/19794#discussion_r3891621855
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/FileSystemBasedLockProvider.java:
##########
@@ -293,9 +293,12 @@ public static TypedProperties getLockConfig(String
tablePath) {
/**
* Returns the default lock file root path.
*
- * <p>IMPORTANT: this path should be shared especially when there is engine
cooperation.
+ * <p>IMPORTANT: this path should be shared especially when there is engine
cooperation. It lives
+ * under the table metadata folder ({@code .hoodie}) so every engine/task
derives the same lock
+ * file location from the table base path. This is also the fallback used by
the constructor when
+ * no explicit lock path is configured, so the two must stay in sync.
*/
private static String defaultLockPath(String tablePath) {
- return tablePath + StoragePath.SEPARATOR + AUXILIARYFOLDER_NAME;
+ return tablePath + StoragePath.SEPARATOR +
HoodieTableMetaClient.METAFOLDER_NAME;
Review Comment:
let's use AUXILIARYFOLDER_NAME instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
