This is an automated email from the ASF dual-hosted git repository.
voonhous pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git
The following commit(s) were added to refs/heads/master by this push:
new 886ebc7d4c1d fix(build): tidy shade config drift ahead of hoisting the
POM flags (#19492)
886ebc7d4c1d is described below
commit 886ebc7d4c1daf5f277cd4231036e1a799d69196
Author: Ranga Reddy <[email protected]>
AuthorDate: Mon Aug 31 20:46:50 2026 +0530
fix(build): tidy shade config drift ahead of hoisting the POM flags (#19492)
Three shade-plugin inconsistencies found while scoping #19466, none of
which changes what any
jar contains today.
hudi-io sets createDependencyReducedPom=false with no explanation, which
reads like an
oversight next to the packaging bundles that all set it true. It is not:
the shaded jar is
attached under the "shaded" classifier and the primary jar stays unshaded,
so the published
POM must keep declaring protobuf-java. Reducing it would strip a dependency
the primary jar
really needs. Recorded as a comment so the next person does not "fix" it.
hudi-timeline-server-bundle was the only packaging bundle setting
createDependencyReducedPom
without also setting dependencyReducedPomLocation, so its reduced POM was
written to the
module root instead of target/. Added, matching the wrapped formatting the
other 16 bundles
use.
hudi-aws-bundle carried a duplicate <artifactSet> include block; removed
the repeat.
Partial fix for #19466 - deliberately not "Closes", since the hoist of the
shade flags into the
root POM, which is the main ask, is not included here.
---
hudi-io/pom.xml | 3 +++
packaging/hudi-aws-bundle/pom.xml | 4 ----
packaging/hudi-timeline-server-bundle/pom.xml | 2 ++
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/hudi-io/pom.xml b/hudi-io/pom.xml
index ab81623db959..3d047fdc15dd 100644
--- a/hudi-io/pom.xml
+++ b/hudi-io/pom.xml
@@ -116,6 +116,9 @@
<goal>shade</goal>
</goals>
<configuration>
+ <!-- The shaded jar is attached under the "shaded" classifier
and the primary jar stays
+ unshaded, so the published POM must keep declaring
protobuf-java: reducing it would strip
+ a dependency the primary jar really needs. -->
<createDependencyReducedPom>false</createDependencyReducedPom>
<shadedArtifactAttached>true</shadedArtifactAttached>
<shadedClassifierName>shaded</shadedClassifierName>
diff --git a/packaging/hudi-aws-bundle/pom.xml
b/packaging/hudi-aws-bundle/pom.xml
index c3fd4b23643f..dd412ea18c10 100644
--- a/packaging/hudi-aws-bundle/pom.xml
+++ b/packaging/hudi-aws-bundle/pom.xml
@@ -109,10 +109,6 @@
<pattern>org.openjdk.jol.</pattern>
<shadedPattern>org.apache.hudi.org.openjdk.jol.</shadedPattern>
</relocation>
- <relocation>
-
<pattern>org.apache.httpcomponents.</pattern>
-
<shadedPattern>org.apache.hudi.aws.org.apache.httpcomponents.</shadedPattern>
- </relocation>
</relocations>
<createDependencyReducedPom>true</createDependencyReducedPom>
<!-- Keep dependencies that are not absorbed into
the shaded jar, so the reduced POM still
diff --git a/packaging/hudi-timeline-server-bundle/pom.xml
b/packaging/hudi-timeline-server-bundle/pom.xml
index 1382a8cd9c49..cb8373269abf 100644
--- a/packaging/hudi-timeline-server-bundle/pom.xml
+++ b/packaging/hudi-timeline-server-bundle/pom.xml
@@ -146,6 +146,8 @@
<version>${maven-shade-plugin.version}</version>
<configuration>
<createDependencyReducedPom>true</createDependencyReducedPom>
+
<dependencyReducedPomLocation>${project.build.directory}/dependency-reduced-pom.xml
+ </dependencyReducedPomLocation>
<filters>
<filter>
<artifact>*:*</artifact>
