hudi-agent commented on code in PR #19767:
URL: https://github.com/apache/hudi/pull/19767#discussion_r3900974337
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/strategy/ClusteringExecutionStrategy.java:
##########
@@ -142,10 +144,24 @@ protected FileSlice clusteringOperationToFileSlice(String
basePath, ClusteringOp
return fileSlice;
Review Comment:
🤖 nit: now that the return type was widened to `HoodieRecordReader`, the
name `getFileGroupReader` is a bit misleading — could you rename it to
something like `getRecordReader` to match what it actually returns?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/clustering/run/strategy/MultipleSparkJobExecutionStrategy.java:
##########
@@ -331,7 +331,7 @@ public Iterator<InternalRow> call(ClusteringOperation
clusteringOperation) throw
Option<InternalSchema> internalSchemaOption =
SerDeHelper.fromJson(internalSchemaStr);
// instantiate FG reader
- HoodieFileGroupReader<InternalRow> fileGroupReader =
getFileGroupReader(metaClient, fileSlice, tableSchemaWithMetaFields,
internalSchemaOption,
+ HoodieRecordReader<InternalRow> fileGroupReader =
getFileGroupReader(metaClient, fileSlice, tableSchemaWithMetaFields,
internalSchemaOption,
Review Comment:
🤖 nit: the local variable `fileGroupReader` still carries the old name —
would `recordReader` (or just `reader`) be more accurate now that its type is
`HoodieRecordReader`?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
