PDGGK commented on PR #19776: URL: https://github.com/apache/hudi/pull/19776#issuecomment-5490069935
You're right, sorry — I had the impact wrong, not just the wording. Reworded, and I moved the measured numbers into the Impact section rather than only fixing the two sentences, since the mistake was in what I thought the change did. Both tests now assert equality with Spark's `HashPartitioner` alongside the range check, with your `Integer.MIN_VALUE % 2^k == 0` comment so the parallelism list doesn't get trimmed later. Took the fixture-assertion nit too. I did take the optional one. `TestCoalescingPartitioner#testShuffleSucceedsForMinValueHashKey` drives a `partitionBy` over a one-row RDD; on the old expression it fails with `ArrayIndexOutOfBoundsException: Index -2 out of bounds for length 3`, so the `BypassMergeSortShuffleWriter` path is pinned rather than just described. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
