LeonxLJX commented on PR #19784: URL: https://github.com/apache/hudi/pull/19784#issuecomment-5492975231
Thanks @utafrali and @voonhous for the review. I've addressed the feedback: 1. **`IOException` recovery test** — added `testGetTopLevelClassesInClasspathHandlesIOException` in `TestReflectionUtils.java`, which installs a context `ClassLoader` whose `getResources` throws and asserts the method returns an empty stream (no propagation). This closes the coverage gap the codecov report flagged. 2. **PR title/body** — now references "Closes #14554" per the hudi contribution template so CI template checks pass. 3. **`toDirectory` naming** — agree `urlToDirectory` is clearer about what it converts; happy to rename if maintainers want it in this PR or a follow-up to keep the diff minimal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
