hudi-agent commented on code in PR #19809:
URL: https://github.com/apache/hudi/pull/19809#discussion_r3905140596
##########
hudi-common/src/main/java/org/apache/hudi/common/avro/HoodieAvroUtils.java:
##########
@@ -1581,15 +1631,17 @@ public static GenericRecord
rewriteRecordDeep(GenericRecord oldRecord, Schema ne
return rewriteRecordWithNewSchema(oldRecord, newSchema,
Collections.EMPTY_MAP, validate);
}
+ @VisibleForTesting
Review Comment:
🤖 nit: `@VisibleForTesting` on a `public` method is a bit contradictory —
the sibling `gteqAvro1_10` was correctly narrowed to package-private to match
the annotation's intent. Could `gteqAvro1_9` follow the same treatment, or if
it has real external callers, drop the annotation?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -110,7 +109,7 @@ public class HoodieMetadataPayload implements
HoodieRecordPayload<HoodieMetadata
private static final HoodieSchema HOODIE_METADATA_SCHEMA =
HoodieSchemaCache.intern(
HoodieSchema.fromAvroSchema(HoodieMetadataRecord.getClassSchema()));
// Cache the Avro schema reference for O(1) equality checks during
Avro.Schema -> HoodieSchema migration
Review Comment:
🤖 nit: the comment above still says 'Cache the Avro schema reference for
O(1) equality checks' but `AvroSchemaCache.intern()` was removed on the next
line — could you update or drop it so it matches what the code actually does?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
