yihua commented on code in PR #678:
URL: https://github.com/apache/hudi-rs/pull/678#discussion_r3909575849
##########
crates/core/tests/gold_parity_tests.rs:
##########
@@ -502,6 +504,26 @@ impl Known {
/// disagreement fails the build, and one that starts passing has to be removed
/// from here, so this list cannot quietly go stale.
const KNOWN: &[Known] = &[
+ // Version 1 only: it applies no completed/inflight check to log blocks, so
+ // the blocks of a delta commit that never completed still reach the merge.
+ // The fixture exists to pin that version 2 does check; this records that
+ // version 1 does not, which is the divergence itself rather than a fixture
+ // flaw. Only the version 6 fixture separates the two readers: on version 9
+ // the log file is dropped when the slice is built, which both of them
share.
+ //
+ // Unlike the other version 1 entries here, which record a narrower or
+ // differently-shaped answer, this one records a wrong one: rows that were
+ // never committed. It is accepted rather than fixed because version 2 is
the
+ // default and version 1 is on its way out. Two things would reopen that: a
+ // version 1 read reachable without asking for it, or version 1 outliving
the
+ // migration. Fixing it means giving `LogFileScanner` the instant state its
+ // `scan` has no notion of, which reaches the metadata table reader too.
+ Known {
+ fixture: "table_uncommitted_log_v6",
+ scope: CaseScope::Any,
+ reader_version: "1",
+ reason: "version 1 admits blocks from an instant that never completed",
+ },
Review Comment:
non-blocking: `CaseScope::Any` here covers `key_only` and `read_optimized`,
which v1 passes on this fixture (the orphan is an update, so the key set is
unchanged, and read-optimized never touches the log). Per the `Any` scope's own
doc, would it be worth naming `SelectStar` plus the four cases that actually
fail, so a later v1 regression on the passing two still trips the ratchet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
