yihua commented on PR #689: URL: https://github.com/apache/hudi-rs/pull/689#issuecomment-5504750416
non-blocking: one question on object-storage performance before this stack's numbers get quoted. The memory win is measured and convincing, but every performance-shaped claim is local so far: the PR's own account says wall time is 7-10% slower on a local filesystem (attributed to lost OS readahead), the round-trip saving from `get_ranges` coalescing is unmeasured, and the header walk's windowed refills change the byte and round-trip profile in ways a local disk cannot show at all. Is an S3 (or other object-store) run of the fg-bench/memory-bench pair planned before the merge-down — ideally with a bytes-fetched counter, which would also answer the window-refill question on `fill_window` above in the same run? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
