HuangZhenQiu commented on code in PR #19805:
URL: https://github.com/apache/hudi/pull/19805#discussion_r3920825975
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java:
##########
@@ -426,12 +428,21 @@ private static DataStream<HoodieFlinkInternalRow>
streamBootstrap(
DataStream<HoodieFlinkInternalRow> dataStream1 =
rowDataToHoodieRecord(conf, rowType, dataStream);
boolean isGlobalRLI = OptionsResolver.isGlobalRecordLevelIndex(conf);
- if (conf.get(FlinkOptions.INDEX_BOOTSTRAP_ENABLED) || (bounded &&
!isGlobalRLI)) {
+ boolean isTimeBoundedRLIBootstrap =
OptionsResolver.isTimeBoundedRLIBootstrapEnabled(conf);
Review Comment:
Good idea for the bootstrap factory. In your previous comment,
HoodieTableFactory set write conf with
conf.set(FlinkOptions.INDEX_GLOBAL_ENABLED, false). In this case, we can't
add the guard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
