yihua opened a new pull request, #715:
URL: https://github.com/apache/hudi-rs/pull/715
## Description
`rust-version = "1.91.1"` is no longer buildable: a fresh resolution pulls
`aws-config` 1.9.0+ and the rest of the aws-smithy family (via `lance-io`),
which declare `rust-version = 1.94.1`. Twenty packages in the graph now require
the newer compiler, so anyone on the documented MSRV gets a hard error. 1.94.1
is exact: `cargo check --workspace --all-features` passes on 1.94.1 and fails
on 1.91.1.
Also updates the MSRV references in AGENTS.md and crates/AGENTS.md per the
maintenance rule in AGENTS.md.
Worth a follow-up decision: nothing in CI compiles with the MSRV toolchain,
which is how this rotted unnoticed, but a naive MSRV CI job would assert a
moving target because `Cargo.lock` is gitignored and `resolver = "2"` is not
MSRV-aware. Guarding this properly means either committing `Cargo.lock` or
moving to the edition-2024 default resolver (v3, which resolves MSRV-compatible
versions), and then adding the CI leg.
## How are the changes test-covered
- [ ] N/A
- [ ] Automated tests (unit and/or integration tests)
- [x] Manual tests
- [x] Details are described below
`cargo +1.91.1 check --workspace --all-features` fails naming the aws
crates; `cargo +1.94.1 check --workspace --all-features` passes for all eight
members. The full workspace test suite (`--all-targets --all-features`) also
runs green on rustc 1.94.1, which the repo's `rust-toolchain.toml` pin already
resolves to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
