yihua opened a new pull request, #717:
URL: https://github.com/apache/hudi-rs/pull/717
## Description
Dry-reading the release guide against the release scripts ahead of 0.5.0
turned up several places where following the guide verbatim fails:
- All three scripts built their work dir as `"$TMPDIR$(date ...)"`, which
aborts under `set -o nounset` on Linux where `TMPDIR` is unset, and silently
produces a wrong path when `TMPDIR` is set without a trailing slash. Now
normalized as `${TMPDIR:-/tmp}` with the trailing slash stripped before joining.
- `verify_src_release.sh` rejected the `alpha.N` and `beta.N` pre-release
versions the guide prescribes (its regex allowed only `rc`);
`upload_src_release_to_dev.sh` validated the version not at all. Both now
accept exactly `X.Y.Z` with an optional `-{alpha|beta|rc}.W`.
- `publish_src_release.sh` never created its work dir before `svn co` into a
subpath of it.
- Guide fixes: the version-bump example now matches
`bump_version_in_main.sh` (`0.5.0-dev` bumps to `0.6.0-dev` or `1.0.0-dev`,
keeping the `-dev` suffix); the publish command drops a signing-key argument
the script ignores; `changelog.md` becomes `CHANGELOG.md`; the tracking-issue
template's hardcoded 0.1.0 milestone link becomes a placeholder.
## How are the changes test-covered
- [ ] N/A
- [ ] Automated tests (unit and/or integration tests)
- [x] Manual tests
- [x] Details are described below
`bash -n` on all three scripts; exercised the work-dir construction with
`TMPDIR` unset, set with a trailing slash (macOS), and set without one; ran the
new version regex against accepted (`0.5.0`, `0.5.0-rc.1`, `0.5.0-alpha.2`,
`0.5.0-beta.1`) and rejected (`0.5.0-rc1`, `0.5.0-alpha`, `0.5.0-dev`) forms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
