voonhous commented on code in PR #19815:
URL: https://github.com/apache/hudi/pull/19815#discussion_r3933395819


##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieStorageConfig.java:
##########


Review Comment:
   Applied in 9a3ea36362b0. `Builder.parquetOutputTimestampType()` now carries 
`@Deprecated` plus a javadoc pointing at the writer schema, following 
`HoodieWriteConfig.Builder.withPopulateMetaFields`. It was the last 
undeprecated surface for this config, and the write side at that: the accessor 
has no callers in the tree, whereas the setter is what a programmatic caller 
actually invokes.
   
   The one cross-class caller is the new test that pins the no-op deliberately, 
so it takes `@SuppressWarnings("deprecation")`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to