yihua commented on code in PR #721:
URL: https://github.com/apache/hudi-rs/pull/721#discussion_r3931237048
##########
Cargo.toml:
##########
@@ -23,7 +23,10 @@ members = [
"benchmark/tpch",
"benchmark/filegroup",
]
-resolver = "2"
+# Resolver v3 is MSRV-aware: a fresh resolution prefers dependency versions
+# whose rust-version fits the declared MSRV, so the promise stays satisfiable
+# without a committed lockfile (the msrv-check CI job then verifies it).
Review Comment:
Remove this
##########
.github/workflows/ci.yml:
##########
@@ -153,6 +153,36 @@ jobs:
fi
done
+ # The MSRV in Cargo.toml `rust-version` is a published promise, but every
+ # other job builds with the rust-toolchain.toml dev pin, so the promise holds
+ # only while the two happen to agree. They diverged from 2026-05 to 2026-09
+ # (dev pin 1.94, declared MSRV 1.91.1) and the declared floor silently became
+ # unbuildable when aws crates raised theirs. This job compiles with the
+ # toolchain the manifest declares, read from Cargo.toml so it follows future
+ # bumps, and starts pulling real weight the moment the dev pin moves ahead of
+ # the MSRV again.
Review Comment:
Simplify the comment; no need to state previous issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
