smtwilio commented on code in PR #19811:
URL: https://github.com/apache/hudi/pull/19811#discussion_r3951558177
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java:
##########
@@ -220,6 +220,16 @@ public void shutdownGracefully() {
});
}
+ // Interrupts an in-progress ingestion, unlike shutdownGracefully() which
lets the current round finish.
+ public void shutdownForcefully() {
Review Comment:
This is was intentional. `shutdownStreamers()` calls this from the
coordinating thread while the sibling's `sync()` is still running, so closing
here would release the resources out from under a live writer. The thread that
ran `sync()` closes it in its finally, same as every other shutdownGracefully()
caller. Happy to rename this to something like `interruptIngestion()`, what do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
