cshuo commented on code in PR #19866:
URL: https://github.com/apache/hudi/pull/19866#discussion_r3955854237
##########
packaging/hudi-flink-bundle/pom.xml:
##########
@@ -222,6 +236,19 @@
<pattern>com.fasterxml.jackson.</pattern>
<shadedPattern>${flink.bundle.shade.prefix}com.fasterxml.jackson.</shadedPattern>
</relocation>
+ <!-- Relocate Arrow's Netty buffer patch together with Netty.
-->
+ <relocation>
+ <pattern>io.netty.</pattern>
Review Comment:
Thanks for pointing this out. The property-name change is expected with the
relocation: configuring Hudi's bundled Netty requires the
`org.apache.hudi.io.netty.*` prefix.
The existing Azure bundle uses the same `io.netty.*` ->
`org.apache.hudi.io.netty.*` relocation. We also checked its built JAR and
confirmed that it reads `org.apache.hudi.io.netty.maxDirectMemory`.
We propose keeping the relocation consistent with the Azure bundle to
isolate Hudi's Netty from other dependencies on the classpath.
##########
packaging/hudi-flink-bundle/pom.xml:
##########
@@ -222,6 +236,19 @@
<pattern>com.fasterxml.jackson.</pattern>
<shadedPattern>${flink.bundle.shade.prefix}com.fasterxml.jackson.</shadedPattern>
</relocation>
+ <!-- Relocate Arrow's Netty buffer patch together with Netty.
-->
+ <relocation>
+ <pattern>io.netty.</pattern>
Review Comment:
The property-name change is expected with the relocation: configuring Hudi's
bundled Netty requires the `org.apache.hudi.io.netty.*` prefix.
The existing Azure bundle uses the same `io.netty.*` ->
`org.apache.hudi.io.netty.*` relocation. We also checked its built JAR and
confirmed that it reads `org.apache.hudi.io.netty.maxDirectMemory`.
We propose keeping the relocation consistent with the Azure bundle to
isolate Hudi's Netty from other dependencies on the classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
