voonhous commented on PR #17675:
URL: https://github.com/apache/hudi/pull/17675#issuecomment-5583801247
Closing as superseded.
#19784 merged and closed #14554 with the simplification the issue asked for.
What is still unfixed on master is jar-entry scanning and the null-package
guard, and #19624 covers both: it reads jar entries through `JarURLConnection`
rather than decoding and splitting the URL string, and it builds directory and
jar fixtures so each protocol is actually exercised.
For the record, one thing to carry forward: the jar branch here drops
subpackages (`!relativePath.contains("/")`) while the directory branch recurses
into them, so the two protocols would return different results for the same
package. The javadoc says subpackages are included.
You found the jar problem first, and #19624 credits that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
