voonhous commented on PR #19624: URL: https://github.com/apache/hudi/pull/19624#issuecomment-5583799464
#19784 merged and closed #14554, but it landed only the simplification. Its own body says so: "This PR does not add JAR-entry scanning." Two of the fixes here are still live on master: 1. `jar:` URLs are now logged and skipped by the new `toDirectory` helper rather than throwing. All 14 bundle `Main` callers run from inside a shaded jar, so they went from `IllegalArgumentException: URI is not hierarchical` to printing nothing. Loud failure became a silent no-op. 2. `ReflectionUtils.java:133` is still `clazz.getPackage().getName()` with no null guard, so `getTopLevelClassesInClasspath(String[].class)` still NPEs. Could we rebase this down to just those two and drop the parts #19784 already covers? The `JarURLConnection` handling and the directory/jar fixtures both still look worth having. Reading the code, the two tests #19784 added look like they would still pass against this implementation, since both invalid URLs fall through to empty streams and the real directory resource still resolves, but I have not run it. Closing #17675, which covers the same ground, in favour of this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
